Runtime Catalogue: replace persistence-manager by storage-manager

[pchainho]

As agreed here

New release is pending on this one.

[jboulmal]

Please @Endebert update dist/ files as well.

[Endebert]

Just pushed a first version of the storageManager usage in RuntimeCatalogue to the develop branch: https://github.com/reTHINK-project/dev-service-framework/commit/1cbf2aaf3a2210f11788ee3e5382b8686e06a4f4

It's untested, since I do not have a test environment with the browser runtime using the master branch at hand. Please tell me how quickly setup such an environment, or, if someone has a matching environment already set up, please test my code and provide feedback.

I believe the code should work as long as my assumptions regarding the storageManager are correct.

[jboulmal]

All right @Endebert I can't test it from runtime-nodejs. However, in we need an updated version in the dist folder.

import { RuntimeCatalogueLocal, RuntimeCatalogue } from 'service-framework/dist/RuntimeCatalogue';
import storageManager  from 'service-framework/dist/storageManager';

[Endebert]

@jboulmal I have updated the dist folder, maybe you are using the master branch instead of develop?

Commit: https://github.com/reTHINK-project/dev-service-framework/commit/6825bdd1de2e286cb2cd8bd593f18f0a7ba3c52b

[jboulmal]

in runtime-nodejs we have only used the develop branch so far.

[Endebert]

Ok, but I pushed the updated dist folder commit together with the updated RuntimeCatalogue commit. Maybe delete the service framework folder and rerun npm install?

[jboulmal]

OK @Endebert!

[jboulmal]

I saw that you have kept the same name PersistanceManager. On runtime-nodejs we got the following error message:

[Endebert]

This is because the nodejs RuntimeFactory does not provide a storageManager() function, like the browser RuntimeFactory does. The RuntimeCatalogue gets access to the storageManager this way, so it needs it to work.

edit: This has nothing to do with PersistanceManager, the persistenceManager is not used by the RuntimeCatalogue anymore.

[Endebert]

changes pushed into new branch, see here: https://github.com/reTHINK-project/dev-service-framework/blob/develop-catalogue-storagemanager/src/runtime-catalogue/RuntimeCatalogue.js

[pchainho]

what is the status of this one?

[Endebert]

No further comments. Changes were merged into the develop branch. Closing issue

[jboulmal]

I have solved this small error by keeping also persistanceManager.