search

reZach / grammarify

Grammarify is a npm package that safely cleans up text that has mispellings, improper capitalization, lexical illusions, among other things.
MIT License
67 stars 10 forks source link

Add support for na = n/a becoming N/A #2

Closed ajoslin103 closed 4 years ago

ajoslin103 commented 4 years ago

This is a special case, perhaps not for everyone

ajoslin103 commented 4 years ago

Excellent change to the modification -- always better to avoid adding special-case code

I didn't notice that you were traversing the mappings until there were no more replacements.

Thank you for making this Repo -- I found it years later, at a time most opportune !!

reZach commented 4 years ago

@ajoslin103 The fix has been pushed to v1.0.2 (it is live on NPM now).

ajoslin103 commented 4 years ago

I'm sorry, but the index.min.js doesn't include the change - do I have to do something else?

reZach commented 4 years ago

@ajoslin103 oops! I can do that tonight, in the meantime can you use index.js until then? Sorry!

reZach commented 4 years ago

@ajoslin103 index.min.js has now been updated with the changes.

ajoslin103 commented 4 years ago

thanks!

On Nov 14, 2019, at 12:11 AM, reZach notifications@github.com wrote:

@ajoslin103 https://github.com/ajoslin103 index.min.js has now been updated with the changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reZach/grammarify/pull/2?email_source=notifications&email_token=AADML5I7ZNDRUO3DSVLD5DDQTTMZFA5CNFSM4JMDX3D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEATMOY#issuecomment-553727547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADML5LK6RCBC4NHF626B2DQTTMZFANCNFSM4JMDX3DQ.