search

reZach / my-budget

Free, open source offline cross-platform budgeting solution built with Electron.
GNU Affero General Public License v3.0
956 stars 61 forks source link

Code quality #9

Closed maiph closed 5 years ago

maiph commented 5 years ago

There are lots of inconsistencies around code formatting. Also when i open the project in vscode after npm i i get errors from eslint all over the project.

Are there any plans to clean up the project and fix those issues?

reZach commented 5 years ago

Hi @maiph, thanks for showing interest in the project.

That is exactly one of the things that is on my to-do list, I'm planning on doing that after I write up support to drag and drop/re-order categories and sub-categories.

maiph commented 5 years ago

I'll be looking forward for that change then.

reZach commented 5 years ago

@maiph the drag-n-drop is getting moved back for the time being. Our first lint run is here (more to come): https://github.com/reZach/my-budget/commit/57b7709841e7cd31a3cab7984c90f05460ec8fc8

reZach commented 5 years ago

@maiph the repo is now linted (error-free), as well as a Azure Pipelines CI build has been set up that runs npm run lint on commits to master and for PRs. The status of the latest build can be found on the README (updated) here.

I do still want to go through and refactor the code, that will come soon. Closing this issue - thanks for asking for this issue to get the conversation started.