Stop combobox esc propagation - Githubissues

reach / reach-ui

The Accessible Foundation for React Apps and Design Systems

https://reacttraining.com/reach-ui/

MIT License

5.97k stars 560 forks source link

Stop combobox esc propagation #968

Open bennetstankidis opened 2 years ago

bennetstankidis commented 2 years ago

Follow up on https://github.com/reach/reach-ui/pull/683 to fix https://github.com/reach/reach-ui/issues/395.

[x] Use a meaningful title for the pull request. Include the name of the package modified.
[ ] Test the change in your own code (Compile and run).
[x] Add or edit tests to reflect the change (Run with yarn test).
[ ] Add or edit Storybook examples to reflect the change (Run with yarn start).
[x] Ensure formatting is consistent with the project's Prettier configuration.
[ ] Add documentation to support any new features.

This pull request:

[ ] Creates a new package
[x] Fixes a bug in an existing package
[ ] Adds additional features/functionality to an existing package
[ ] Updates documentation or example code
[ ] Other

If creating a new package:

[ ] Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
- [ ] examples directory
- [ ] src directory with an index.tsx entry file
- [ ] At least one example file per feature introduced by the new package
- [ ] Base styles in a style.css file (if needed by the new package)

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a53bb809f596d0febef8825ceea4419bb123bf3f:

Sandbox	Source
reach-ui-template	Configuration