reach / router

https://reach.tech/router
MIT License
6.91k stars 326 forks source link

Query Params ignored for isCurrent #479

Open SimonChaumet opened 2 years ago

SimonChaumet commented 2 years ago

Bug

When using query params (search params) the query is ignored when taken from location but it's not when using the "to" parameter, so isCurrent will never be true when using query params. I think this is the corresponding code.

I know that it might be a problem for the specifications but I think a consistent logic would be to ignore the query params from the "to" parameter.

See CodeSandbox

I may provide a pull request if the specification is good for you