Closed par4m closed 8 months ago
Would you be interested in automated tests ? Running the script as a service instead of a one-time cleanup
Would you be interested in automated tests ?
You mean a rust #[test]
? I don't think it's necessary for this function.
Running the script as a service instead of a one-time cleanup
I am also thinking about this. Currently the way I see the end user using it is to create a binary (via cargo build), and put it in a crontab. Or maybe a docker container.
What do you mean by "run as a service"?
Can you also fix the failing tests here?
Not sure if the failing CI action is due to code change or a simple fluke. Could you resolve conflicts and let's retry?
Not sure if the failing CI action is due to code change or a simple fluke. Could you resolve conflicts and let's retry?
Seems like a fluke, I've barely changed anything and as far as I know the tests had passed on the first commit ? I'll check the logs and try to fix it
I've resolved the conflicts, let's see if the tests pass now.
Do you have any ideas how to fix it in the Github action file?
What worries me is that this same action passes on Github, and on other PRs like https://github.com/reacherhq/check-if-email-exists/pull/1370, so it is related to this PR?
Do you have any ideas how to fix it in the Github action file?
What worries me is that this same action passes on Github, and on other PRs like #1370, so it is related to this PR?
Seems like a very prominent issue https://github.com/sfackler/rust-openssl/issues?q=is%3Aissue++action+
Weird that the Action is still failing. I'll merge this PR, I'll figure out later.
Two things before I merge (same comments as https://github.com/reacherhq/check-if-email-exists/pull/1377#pullrequestreview-1729118309, seems like they were reverted):
Thanks! Merging, let's hope the failing check was just a fluke on this PR.
#1144