Prune bulk email verification database

reacherhq / check-if-email-exists

Check if an email address exists without sending any email, written in Rust. Comes with a ⚙️ HTTP backend.

https://reacher.email

Other

4.27k stars 328 forks source link

Prune bulk email verification database #1377

Closed par4m closed 8 months ago

par4m commented 9 months ago

#1144

CLAassistant commented 9 months ago

All committers have signed the CLA.

par4m commented 9 months ago

Would you be interested in automated tests ? Running the script as a service instead of a one-time cleanup

amaury1093 commented 9 months ago

Would you be interested in automated tests ?

You mean a rust #[test]? I don't think it's necessary for this function.

Running the script as a service instead of a one-time cleanup

I am also thinking about this. Currently the way I see the end user using it is to create a binary (via cargo build), and put it in a crontab. Or maybe a docker container.

What do you mean by "run as a service"?

amaury1093 commented 9 months ago

Can you also fix the failing tests here?

amaury1093 commented 9 months ago

Not sure if the failing CI action is due to code change or a simple fluke. Could you resolve conflicts and let's retry?

par4m commented 9 months ago

Not sure if the failing CI action is due to code change or a simple fluke. Could you resolve conflicts and let's retry?

Seems like a fluke, I've barely changed anything and as far as I know the tests had passed on the first commit ? I'll check the logs and try to fix it

par4m commented 9 months ago

I've resolved the conflicts, let's see if the tests pass now.

par4m commented 9 months ago

Seems like an openssl-sys issue

https://github.com/sfackler/rust-openssl/issues/1021#issuecomment-441385845 https://github.com/sfackler/rust-openssl/issues/1021#issuecomment-441387063

amaury1093 commented 9 months ago

Do you have any ideas how to fix it in the Github action file?

What worries me is that this same action passes on Github, and on other PRs like https://github.com/reacherhq/check-if-email-exists/pull/1370, so it is related to this PR?

par4m commented 9 months ago

Do you have any ideas how to fix it in the Github action file?

What worries me is that this same action passes on Github, and on other PRs like #1370, so it is related to this PR?

Seems like a very prominent issue https://github.com/sfackler/rust-openssl/issues?q=is%3Aissue++action+

amaury1093 commented 9 months ago

Weird that the Action is still failing. I'll merge this PR, I'll figure out later.

Two things before I merge (same comments as https://github.com/reacherhq/check-if-email-exists/pull/1377#pullrequestreview-1729118309, seems like they were reverted):

can you rename DEBUG_MODE to DRY_RUN
can you add a small paragraph in the backend's README?

amaury1093 commented 8 months ago

Thanks! Merging, let's hope the failing check was just a fluke on this PR.