chore: 🔧 refactor create npm package script

react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.

https://react-boilerplate.github.io/react-boilerplate-cra-template/

MIT License

1.87k stars 395 forks source link

chore: 🔧 refactor create npm package script #143

Closed nosycode closed 3 years ago

nosycode commented 3 years ago

Сhanges simplify the code and add support for namespaces in the package name (e.g. @react-boilerplate/cra-template-rb)

[x] You have followed our contributing guidelines
[x] Double-check your branch is based on dev and targets dev
[ ] Pull request has tests (we are going for 100% coverage!)
[ ] Code is well-commented, linted and follows project conventions
[ ] Documentation is updated (if necessary)
[ ] Internal code generators and templates are updated (if necessary)
[x] Description explains the issue/use-case resolved and auto-closes related issues

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1113725789

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.678%

Totals
Change from base Build 1109812289:	0.0%
Covered Lines:	249
Relevant Lines:	249

💛 - Coveralls

Can-Sahin commented 3 years ago

Thanks for the effort but these are not the things to change. It's already quite explicit what the code is there and I want to have minimal changes in internal stuff because they are already working work 1+ year and I don't have too much time to maintain new changes