react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 395 forks source link

chore: 🔧 add support of scoped package name #145

Closed nosycode closed 3 years ago

nosycode commented 3 years ago

Сhanges simplify the code and add support for scope in the package name (e.g. @react-boilerplate/cra-template-rb)

I added a comment and replaced the non-obvious regex. This changes will add the ability to rename the package to scoped package in the fork and publish user's templates based on react-boilerplate-cra-template.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1118929144


Totals Coverage Status
Change from base Build 1109812289: 0.0%
Covered Lines: 249
Relevant Lines: 249

💛 - Coveralls
Can-Sahin commented 3 years ago

ok i will merge this but repeating myself again. Internal template changes should only happen with respect to a bug or to really obvious problems. They are hard to test, can vary in environments, can be forgotten in the future(coz they are not updated at all once they work) so on...

Anybody wishing to publish their own template could easily do it and I surely don't prioritize modifying the template to make this specific thing easier for instance ;)

If you want to help with the template it's definitely most appreciated. Rather than internal changes, we should focus on the real template changes. See what's new in react world, what has changed, what's better etc. I am having a hard time keeping up with this.