chore(deps): bump dependencies

react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.

https://react-boilerplate.github.io/react-boilerplate-cra-template/

MIT License

1.87k stars 393 forks source link

chore(deps): bump dependencies #146

Closed nosycode closed 2 years ago

nosycode commented 3 years ago

[x] You have followed our contributing guidelines
[x] Double-check your branch is based on dev and targets dev
[ ] Pull request has tests (we are going for 100% coverage!)
[ ] Code is well-commented, linted and follows project conventions
[ ] Documentation is updated (if necessary)
[ ] Internal code generators and templates are updated (if necessary)
[ ] Description explains the issue/use-case resolved and auto-closes related issues

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1159887620

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.678%

Totals
Change from base Build 1139991314:	0.0%
Covered Lines:	249
Relevant Lines:	249

💛 - Coveralls

Can-Sahin commented 3 years ago

This is ABSOLUTELY no go. You can't bump things to versions released only 5 hours ago. Dependency management is an extremely hard task. CRA doesn't support recent versions of typescript on top of it. You need to read every changelog and bump one by one checking if they break something. It takes hours when I do version bumps ;)

I can understand your motivation but slow down with PR, please. It's not always good to update and aggressively fix things. Maybe open an issue if you want to suggest something and we can talk before you implement it.

Read this maybe: https://github.com/react-boilerplate/react-boilerplate-cra-template/issues/131

nosycode commented 3 years ago

@Can-Sahin thanks for your feedback.

I understand your position, it has a place to be. Maybe you can make a clear list of criteria for upgrading a package to a new version? I spent several hours updating packages, reading their changelog and running tests...

I also ask for additional information regarding the typescript version. When I install the official CRA with the typescript, the latest version 4.3.5 is installed, which is valid for the specified pattern "^4.1.2". Where can I find information about the invalidity of this version you are writing about?

Can-Sahin commented 3 years ago

ok then cool. Most people think it's easy to just bump the version. I should write a list of what to verify manually even though the tests are passing. There are some checks as well, tests cannot cover everything. It has to wait a bit because I am quite busy in august. I also did a version bump commit lately. It's not super important to keep up-to-date always.

I don't remember where it's written but I remember seeing 'using ts version xxx and cra supports yyy' when you 'yarn start'. And typescript is quite problematic with CRA. Had so many issues in the past. I decided to run keep at least 3 months for typescript and core libraries like redux, react, react-dom, etc. I have been in react and the boilerplate world for 4 years and I believe it's best for the majority. Anybody can update after installation anyway.

Can-Sahin commented 3 years ago

I am opening it back again just as a reminder to me. But for the next couple weeks, I don't have time for this repo sorry.