search

react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 393 forks source link

Compatibility with CRA 5 #152

Closed vtrphan closed 2 years ago

vtrphan commented 2 years ago

Is your feature request related to a problem? Please describe. CRA version 5 is out, also plop and node-plop are gone to a new major version. Will this awesome template be updated accordingly?

Can-Sahin commented 2 years ago

I will get into this month. I had been busy a lot lately. Thanks for the update

safranx commented 2 years ago

Hello @Can-Sahin,

When did you expect to "ship/update" your boilerplate with the CRA v5?

Best,

Can-Sahin commented 2 years ago

I decided not to update plop.js simply because they have complicated the usage with TS. I will wait until these are resolved. Actually, all the dependencies that became pure ESM modules are delayed intentionally because TS and CRA are not completely ready for this.

So, working on the rest of the dependencies... Should be done in a few days

See the issues: https://github.com/plopjs/plop/issues/192, https://github.com/plopjs/plop/issues/296, https://github.com/plopjs/plop/issues/297, https://github.com/microsoft/TypeScript/issues/46452

Can-Sahin commented 2 years ago

FYI. I have to wait till CRA fixes this hot issue. Otherwise, I have to add those workarounds to package.json which will be completely obsolete after the fix. I will wait couple of days to see if they are fixing it.

https://github.com/facebook/create-react-app/issues/11930

Can-Sahin commented 2 years ago

Released and closing 👍