react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 395 forks source link

chore: 🔧 releasing 1.2.5 #176

Closed rejochandran closed 2 years ago

rejochandran commented 2 years ago

React version bump to 18.1.0 For https://github.com/react-boilerplate/react-boilerplate-cra-template/issues/168

Changes:

Bump React version to 18.1.0 Update render methods Updated testing methods

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2501809713


Totals Coverage Status
Change from base Build 2157020623: 0.0%
Covered Lines: 249
Relevant Lines: 249

💛 - Coveralls
marcosiglesias1989 commented 2 years ago

@rejochandran nice one!! 💯 Really needed, the first thing I do after creating a new project with this template is update react hehe

@Can-Sahin considere it 👍

Markkos89 commented 2 years ago

@rejochandran I think you also can change the tsconfig.json file, in the CompilerOptions the "jsx" field with :

"jsx": "react-jsx",

Regards,

rejochandran commented 2 years ago

@rejochandran I think you also can change the tsconfig.json file, in the CompilerOptions the "jsx" field with :

"jsx": "react-jsx",

Regards,

@Markkos89, this is already in place: https://github.com/react-boilerplate/react-boilerplate-cra-template/blob/dc7a46381b6fc6614580a4c4c6269d9fb75cba95/tsconfig.json#L18

Did you refer to any other reference?

Markkos89 commented 2 years ago

@rejochandran I think you also can change the tsconfig.json file, in the CompilerOptions the "jsx" field with : "jsx": "react-jsx", Regards,

@Markkos89, this is already in place:

https://github.com/react-boilerplate/react-boilerplate-cra-template/blob/dc7a46381b6fc6614580a4c4c6269d9fb75cba95/tsconfig.json#L18

Did you refer to any other reference?

you are right, apologies, and thanks for the PR !