search

react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 392 forks source link

chore(deps): update jest & styled-components #196

Closed qeleb closed 2 years ago

qeleb commented 2 years ago

updating jest & styled-components

I've updated the styled-components package and the jest packages. This dependency bump has been thoroughly tested and is safe.

Can-Sahin commented 2 years ago

Hey hey. Maybe slow down for a while. I see lot of PRs.

1 - Why all separately? 2 - What do you mean by tested thoroughly? You are sending so much PR and it looks suspicious. You cannot just update a deps and run tests and be done. It could break a lot of little things quite hidden. Its not as easy as people think generally. You have to read changelogs.

Can-Sahin commented 2 years ago

If you combine all these PRs into one I will look at it. Otherwise its impossible for me to test them one by one. Sorry.

qeleb commented 2 years ago

i spent about 10 hours working on this today and thought it would be easier to give separately. I can easily put this into one PR.

I did not make all of these changes today. I have been using this boilerplate for about 2 months and am just trying to move my upgrades and changes upstream.

I have been testing a ton, reading the changelogs, and monitoring the dependency graph. I am extremely certain that my changes are stable. I also updated some dependencies that required code changes, like switching to react router v6.

Can-Sahin commented 2 years ago

Then lets proceed in a single PR. Thanks.