Closed qeleb closed 1 year ago
Totals | |
---|---|
Change from base Build 3037812048: | 0.0% |
Covered Lines: | 250 |
Relevant Lines: | 250 |
Apologies for not noticing the commitlint requirements sooner. I am developing on Windows, so the .sh files didn't execute, preventing me from being warned about commit message formatting.
In my next PR, I plan to:
Hey. Thanks a lot. Sorry for the delay. Im on vacation for 2 weeks. I ll check this perhaps afterwards :(
@Can-Sahin I hope you enjoyed your vacation! When you get a chance, could you take a look at this PR? I have a few more things I'd like to do after it's merged.
Also, I've been digging into React Scripts... there is so much stuff in there that needs updating. It's sort of sad to see how poorly maintained the CRA core has become. I may write my own soon... but if I do, I'd probably build it with SolidJS or maybe Preact.
When you come back from vacation your actual work piles up on you :) I'll be looking next week :)
About CRA yes it's not as active as old days but it's mature and accepted by the community. It always comes down to the community of the software in the end. I and some other people I know have maintained CRA apps (mines are simpler) for 4-5 years now and trust me the custom and new stuff always come and bite you in harsh ways, but the motivation in the beginning feels good I know :)
Thanks. I wanna release a version with your changes in couple of days. Sounds good?
yes it does. should the editor not auto format? i love this feature
This pull request has a lot of things in it, but it's really scaled-back compared to the last one.