react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 394 forks source link

service worker not running when i build #72

Closed sureshtidbit closed 4 years ago

sureshtidbit commented 4 years ago

Description

when you just clone then project and build project after then start using serve or start in domain. service worker is running and also build do not create sw.js file also. A clear and concise description of what the bug is.

Steps to reproduce

when you just clone then project and build project after then start using serve or start in domain. then open domain in google chrome and check in application tab no service worker will be there for this website. Steps to reproduce the behavior:

Expected behavior service worker should be there and registered in application tab of google chrome. because of that only used files should be fetched from server only.

Versions

latest just download

sureshtidbit commented 4 years ago

any update on this?

Can-Sahin commented 4 years ago

First of all this is not a premium help service. It's rude to ask for an update after 5 days.

You can't just clone and expect it to work magically. Look at my comment. Plus this project is never meant to clone. This is NOT how you use it.

sureshtidbit commented 4 years ago

sorry if you do not like.

second i do as per documentation and build code and run in domain. same problem service worker not created in application tab.

if service not working as per google chrome then can you give me idea how this is working then?

sureshtidbit commented 4 years ago

ok i understood now.