search

react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 394 forks source link

TypeError: Cannot add property noFallthroughCasesInSwitch, object is not extensible #77

Closed vaibhavarora14 closed 4 years ago

vaibhavarora14 commented 4 years ago

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

Description

Tried running command npx create-react-app --template cra-template-rb project-name and got error in setup (pasted screenshot), situated in node_modules\react-scripts\scripts\utils\verifyTypeScriptSetup.js:231 image

Steps to reproduce

Steps to reproduce the behavior:

(Add link to a demo on https://jsfiddle.net or similar if possible)

Expected behavior It should be able to generate the project

Screenshots If applicable, add screenshots to help explain your problem.

Versions

vaibhavarora14 commented 4 years ago

some details of same are mentioned in https://github.com/facebook/create-react-app/issues/9429

sureshtidbit commented 4 years ago

same issue. suggested link: https://stackoverflow.com/questions/64115884/error-when-updating-create-react-app-to-4-0-with-typescript-template

Can-Sahin commented 4 years ago

ok thanks. How the hell did this happen. They introduced a breaking change in CRA I dont understand lol?

vaibhavarora14 commented 4 years ago

It was a pending bug in v4.0.0 and got released 3 days ago. I don't know why, but it's a blocker for our template at the time ⛔

vaibhavarora14 commented 4 years ago

@Can-Sahin new commit hasn't trigger the release pipeline. because of "chore:" keyword being used?

Can-Sahin commented 4 years ago

Fixed with https://github.com/react-boilerplate/react-boilerplate-cra-template/commit/8068c36955812024972436f52195a3945aaa6008

Thanks