react-boilerplate / react-boilerplate-cra-template

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
https://react-boilerplate.github.io/react-boilerplate-cra-template/
MIT License
1.87k stars 394 forks source link

Typescript intellisense not updating for translations.json in i18n.ts file #83

Closed vaibhavarora14 closed 3 years ago

vaibhavarora14 commented 4 years ago

Description

Typescript compilation of translations data in i18n.ts have some problem, and not happening while changes are made in translation.json file.

Steps to reproduce

Steps to reproduce the behavior:

Expected behavior It should update the intellisense and basically typescript compilation should work fine in project

Screenshots If applicable, add screenshots to help explain your problem.

image image

Above was exact copy, and now we see original file

image image

Versions

Can-Sahin commented 3 years ago

I dont know why. It has nothing to do with boilerplate. Its purely typescript related isn't it?

vaibhavarora14 commented 3 years ago

it is for sure typescript related, but because translations as feature are provided in this boilerplate. we will have to entertain this bug somehow, to improve boilerplate usage and adoption.

Can-Sahin commented 3 years ago

Its a very very minor thing. If yu can fix it then it would be great and PR welcome but I won't focus on this issue in my limited time for this project