search

react-bootstrap / react-overlays

Utilities for creating robust overlay components
https://react-bootstrap.github.io/react-overlays
MIT License
899 stars 222 forks source link

fix(usePopper): fix exported Modifier type #1013

Closed iz-podpolja closed 2 years ago

iz-podpolja commented 2 years ago

As per title, fixes: https://github.com/react-bootstrap/react-overlays/issues/1012

kyletsang commented 2 years ago

Thanks for the PR. Could you run prettier on your code?

iz-podpolja commented 2 years ago

Thanks for the PR. Could you run prettier on your code?

Sure - done.

kyletsang commented 2 years ago

Thanks. Prettier looks good on the code, but we don't need those changes on the changelog

kyletsang commented 2 years ago

There's also this error

Type 'undefined' does not satisfy the constraint 'Obj'.
iz-podpolja commented 2 years ago

There's also this error

Type 'undefined' does not satisfy the constraint 'Obj'.

Ok, excluded the changelog.md from prettier output and added a util to proxify undefined with Popper.Obj. Tests, lint & tsc --noEmit are green for me.

kyletsang commented 2 years ago

Thanks!