react-bootstrap / react-overlays

Utilities for creating robust overlay components
https://react-bootstrap.github.io/react-overlays
MIT License
897 stars 223 forks source link

Exit stages of transition on modal don't seem to run #971

Open jarcoal opened 3 years ago

jarcoal commented 3 years ago

Describe the bug

When providing a transition in the Modal component, the exit stages of the transition don't seem to run when show is set to false after being true.

Reproducible Example

Here is a full reproduction: https://codesandbox.io/s/react-modal-transition-issue-5j4sz

You can inspect element on the modal to see that it never gets the ...-exit-active classes from CSSTransition.

Expected behavior

I would expect the exit classes to be applied, but the modal seems to unmount from the DOM instantly, not giving them a chance to run.