search

react-bootstrap / react-router-bootstrap

Integration between React Router and React-Bootstrap
Apache License 2.0
1.69k stars 158 forks source link

Fix webpack config #225

Closed jochenberger closed 7 years ago

jochenberger commented 7 years ago

In #201, the switch to react-router-dom was made but the webpack config was not updated. Therefore, the current UMD bundles include react-router-dom and depend on react-router.

jochenberger commented 7 years ago

Before:

ReactRouterBootstrap.js : 187469 bytes
ReactRouterBootstrap.min.js: 65910 bytes

After:

ReactRouterBootstrap.js: 40025 Bytes
ReactRouterBootstrap.min.js: 6459 Bytes
jochenberger commented 7 years ago

Btw, it might be a good idea to add prop-types to the externals, but that would be an incompatible change, so if you want to do it, you'll probably want to postpone it for the next minor release. I can create a PR if you like.

taion commented 7 years ago

Released as v0.24.3. Thanks!