react-bootstrap / react-router-bootstrap

Integration between React Router and React-Bootstrap
Apache License 2.0
1.69k stars 158 forks source link

Publish a new release #249

Closed gurkerl83 closed 5 years ago

gurkerl83 commented 5 years ago

Is it possible to publish a new release which includes the context-fix anytime soon to npm, thx.

kfitzgerald commented 5 years ago

I'm guessing this may need a major rev bump, since the module now exports a wrapped component instead of the original component. The docs may need some love to show this as well.

For example:

// with imports:
import LinkContainer from 'react-router-bootstrap'; // wrapped LinkContainer component
import { LinkContainer as UnwrappedLinkContainer } from 'react-router-bootstrap/lib/LinkContainer'; // original component

// with require
const LinkContainer = require('react-router-bootstrap').LinkContainer;
const UnwrappedLinkContainer = require('react-router-bootstrap/lib/LinkContainer').LinkContainer;

Anyone who implemented custom components extending LinkContainer may be in for a surprise. The unwrapped component is still accessible, but a bit cumbersome to get at if someone wanted to wrap it themselves. Could consider exporting it in index as UnwrappedLinkContainer or something to that effect.

/cc @v12

meetajhu commented 5 years ago

Even i have the same problem with React Router v4.4.0+

v12 commented 5 years ago

Thanks all for your contributions! New version (0.25.0) has been published and should resolve your issues. I'll update readme and changelog to include details about the changes.