search

react-bootstrap / react-router-bootstrap

Integration between React Router and React-Bootstrap
Apache License 2.0
1.69k stars 158 forks source link

`LinkContainer` turns all children's tags into `a`'s. #261

Open dennisoelkers opened 4 years ago

dennisoelkers commented 4 years ago

We are currently upgrading from react-router v3 to v5, therefore also upgrading react-router-bootstrap from v0.23.3 to v0.25.0. We have noticed that LinkContainer (which is just wrapping Route) is turning all children into a-tags, even though e.g. a Button component is passed.

Is this on purpose? Is there any way around this?

Right now it is breaking our tests (we are assuming e.g. that a button component is used in some places).

antoHuman commented 2 years ago

This is something that I expect, as it works well with react bootstrap Button component. The final element is an anchor a with the style of a button.