react-component / collapse

React Collapse / Accordion

http://react-component.github.io/collapse/

MIT License

324 stars 134 forks source link

chore: refactor collapsible value #179

Closed kerm1it closed 3 years ago

kerm1it commented 3 years ago

改动点

3.0.0 中 collapsible 属性取值为 boolean、header，因为之前 @afc163 说的，false 和 disabled 样式和语义上有所区别，所以这次，把此属性的取值修改为 header、disabled，去掉了之前的 boolean。

这次的改动相对于 3.0.0 来说改动还是比较大，所以大家看看有没有遗漏的地方或者不合适的，还需要确认的是这次的改动是发一下 major 还是 minor 版本。

@zombieJ

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/collapse/2l9jd4546
✅ Preview: https://collapse-git-refactor-collapsible.react-component.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #179 (44eba57) into master (f94fa20) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files           4        4           
  Lines         105      105           
  Branches       32       33    +1     
=======================================
  Hits          104      104           
  Misses          1        1

Impacted Files	Coverage Δ
src/Collapse.tsx	`100.00% <100.00%> (ø)`
src/Panel.tsx	`96.77% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f94fa20...44eba57. Read the comment docs.

zombieJ commented 3 years ago

还未实装，minor 我觉得 ok 的。

kerm1it commented 3 years ago

minor 没有问题，我担心的是直接使用 rc 的用户，会有不兼容的情况出现。