react-component / collapse

React Collapse / Accordion
http://react-component.github.io/collapse/
MIT License
323 stars 133 forks source link

refactor: Collapse to function component #287

Closed Wxh16144 closed 1 year ago

Wxh16144 commented 1 year ago
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
collapse ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 6:31AM (UTC)
codecov[bot] commented 1 year ago

Codecov Report

Merging #287 (5dd6a35) into master (4abce43) will increase coverage by 0.40%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   98.44%   98.85%   +0.40%     
==========================================
  Files           4        4              
  Lines         129       87      -42     
  Branches       39       33       -6     
==========================================
- Hits          127       86      -41     
+ Misses          2        1       -1     
Impacted Files Coverage Δ
src/PanelContent.tsx 90.90% <ø> (ø)
src/Collapse.tsx 100.00% <100.00%> (ø)
src/Panel.tsx 100.00% <100.00%> (+2.12%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

afc163 commented 1 year ago

Is is still WIP ?

Wxh16144 commented 1 year ago

Is is still WIP ?

是的,计划把 CC 重构为 FC,然后再解决这个问题

Wxh16144 commented 1 year ago

wait #294

Wxh16144 commented 1 year ago

wait #294

ready~

Wxh16144 commented 1 year ago

这个提交 导致测试覆盖率下降了

zombieJ commented 1 year ago

Test 文件能先不换不,我看有的 keyPress 改成了 keyDown。重构需要避免有逻辑变化。

Wxh16144 commented 1 year ago

Test 文件能先不换不,我看有的 keyPress 改成了 keyDown。重构需要避免有逻辑变化。

那先 revert HEAD~2 ?

zombieJ commented 1 year ago

能趁此补一下测试用例不?把覆盖率拉上去

Wxh16144 commented 1 year ago

能趁此补一下测试用例不?把覆盖率拉上去

ready~