search

react-component / dialog

React Dialog
https://dialog.react-component.vercel.app/
MIT License
434 stars 188 forks source link

Accessibility: Focusable div at beginning of modals #429

Open Watso196 opened 4 months ago

Watso196 commented 4 months ago

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Open modal
  2. Use keyboard Tab key to move focus
  3. Note that focus is "lost" (become invisible) after moving past the OK button, due to focus moving to the hidden div at the top of the modal

What is expected?

Focus should stay within the modal, moving between interactive elements, and should not disappear at any point

What is actually happening?

Focus visually disappears when landing on the non-interactive and invisible hidden

at the top of the modal

Environment | Info -- | -- antd | 5.17.0 React | 17 System | Mac Sonoma 14.4.1 (23E224) Browser | Version 124.0.6367.158 (Official Build) (arm64)

This is technically a failure of the Focus Visible and Focus Order WCAG guidelines:
Focus Visible: https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html
Focus Order: https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html