Open CooperHash opened 6 months ago
And, some new test case is needed.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.58%. Comparing base (
4ae012f
) to head (57b5938
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
And, some new test case is needed.
i have no idea how to mock overflow
@zombieJ @yoyo837 When should this PR be expected in the release?
@zombieJ @yoyo837 When should this PR be expected in the release?
I haven't written the test yet, so you'll need to wait for me to finish writing it before they can review it.
ref: #668
background
When we set the popupOffset, we expect all submenus to have an offset from the menu item. However, when the window width is small, the menu overflows. The overflow, represented by ... as an overflow placeholder, does not have a submenu offset.
It is necessary to fix it
before fix:
https://github.com/react-component/menu/assets/73218815/851a744b-3415-4142-8fc4-777c85efb273
after fix:
https://github.com/react-component/menu/assets/73218815/b33cc2f3-e1cc-4fd0-a570-1046c6769ffd