react-component / pagination

React Pagination
https://pagination-react-component.vercel.app/
MIT License
658 stars 327 forks source link

refactor: refactoring to Function Component #514

Closed Wxh16144 closed 7 months ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Nov 28, 2023 6:20am
afc163 commented 1 year ago

还在搞么

Wxh16144 commented 1 year ago

还在搞么

嗯, 搞的

zombieJ commented 8 months ago

其实可以直接改或者加个不提交的文件备份,改名 deprecated 的话很容易冲突

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ac879ed) 93.31% compared to head (e711387) 98.66%. Report is 2 commits behind head on master.

Files Patch % Lines
src/Pagination.tsx 98.98% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #514 +/- ## ========================================== + Coverage 93.31% 98.66% +5.35% ========================================== Files 5 3 -2 Lines 374 300 -74 Branches 140 133 -7 ========================================== - Hits 349 296 -53 + Misses 24 4 -20 + Partials 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

afc163 commented 7 months ago

覆盖度掉的有点多。

Wxh16144 commented 7 months ago

Ready~,随时 review

MadCcc commented 7 months ago

image 看看补下

Wxh16144 commented 7 months ago

看看补下

看了一下详情,感觉可以不用 care ,不过我会尽量尝试补充一下

Wxh16144 commented 7 months ago

@MadCcc 这个 pr 有一个地方可能有差异,就是我把 example/xxx 的 demo 都 mount 然后做了快照测试,但是今天 push 到 ci 发现快照有问题,怀疑和 rc-select 更新有关,然后我就提交了更新后的快照提交记录 并且还会影响 antd 那边 分页器的快照, 不知道付不符合预期🤔

vercel[bot] commented 7 months ago

Deployment failed with the following error:

Resource is limited - try again in 11 minutes (more than 100, code: "api-deployments-free-per-day").
MadCcc commented 7 months ago

这个 PR 可以合了,再开一个 PR 迁移 enzyme 到 testing library

afc163 commented 7 months ago

https://github.com/react-component/pagination/releases/tag/v4.0.0

li-jia-nan commented 7 months ago

antd 侧是不是还需要更新一下版本号?