search

react-component / pagination

React Pagination
https://pagination-react-component.vercel.app/
MIT License
658 stars 327 forks source link

feat: extends showSizeChanger prop #533

Closed jacklee814 closed 7 months ago

jacklee814 commented 7 months ago

#46070

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Nov 29, 2023 4:39am
jacklee814 commented 7 months ago

@afc163 這樣如何呢？

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac879ed) 93.31% compared to head (0a3a337) 93.12%. Report is 9 commits behind head on master.

:exclamation: Current head 0a3a337 differs from pull request most recent head 53aee8e. Consider uploading reports for the commit 53aee8e to get more accurate results

Files Patch % Lines
src/Pagination.tsx 88.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #533 +/- ## ========================================== - Coverage 93.31% 93.12% -0.20% ========================================== Files 5 5 Lines 374 378 +4 Branches 140 146 +6 ========================================== + Hits 349 352 +3 - Misses 24 25 +1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Wxh16144 commented 7 months ago

这应该需要补充一份测试用例？

afc163 commented 7 months ago

覆盖率掉了

jacklee814 commented 7 months ago

我來補上測試

jacklee814 commented 7 months ago

我等這個 merge 吧 https://github.com/react-component/pagination/pull/539