react-component / pagination

React Pagination
https://pagination-react-component.vercel.app/
MIT License
658 stars 327 forks source link

test: migrate tests to testing-library #539

Closed Wxh16144 closed 7 months ago

Wxh16144 commented 7 months ago

Background: https://github.com/react-component/pagination/pull/514#issuecomment-1829177916

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Nov 29, 2023 4:23am
Wxh16144 commented 7 months ago

Ready~, review at any time

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a513003) 98.66% compared to head (745be0b) 98.69%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #539 +/- ## ========================================== + Coverage 98.66% 98.69% +0.02% ========================================== Files 3 3 Lines 300 306 +6 Branches 133 136 +3 ========================================== + Hits 296 302 +6 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Wxh16144 commented 7 months ago

这里 https://github.com/react-component/pagination/pull/539/commits/ae341639c330f9184171721f736b7fa29a232326 可能需要确认一下?

afc163 commented 7 months ago

没问题,不需要额外的 types 配置了。

afc163 commented 7 months ago

测试文件也重构成 ts ?

Wxh16144 commented 7 months ago

这里 https://github.com/react-component/pagination/pull/539/commits/ae341639c330f9184171721f736b7fa29a232326 可能需要确认一下?

测试文件也重构成 ts ?

重构了,顺手补充了一下 ts 类型 see:https://github.com/react-component/pagination/pull/539/commits/745be0b66b51ebb9f6b227b6eb44683cf4c46437