search

react-component / pagination

React Pagination
https://pagination-react-component.vercel.app/
MIT License
658 stars 325 forks source link

#543 causes a typescript issue when building with the latest version of `rc-pagination` #547

Closed heath-freenome closed 6 months ago

heath-freenome commented 6 months ago

The change in #543 is causing a typescript issue when I am attempting to build with the latest version of rc-pagination I'm seeing:

> tsc -b

node_modules/rc-pagination/lib/index.d.ts:2:1 - error TS1383: Only named exports may use 'export type'.

2 export type * from './interface';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you change this to export * from./interfaceI believe things will do what you want and avoids this typescript error. This works fine becauseinterface.ts` is just a collection of types

afc163 commented 6 months ago

Could you provide a reproduce codesandbox?

heath-freenome commented 6 months ago

@afc163 Would a link to a failing repo branch work? I discovered this while attempting to upgrade the packages on the library I'm maintaining in https://github.com/rjsf-team/react-jsonschema-form

Here's the PR with the failing build: https://github.com/rjsf-team/react-jsonschema-form/pull/4006