react-component / pagination

React Pagination
https://pagination-react-component.vercel.app/
MIT License
658 stars 325 forks source link

Pagination's pageSizeOptions Select component's showSearch props handled dynamically. #554

Open prakashks20 opened 6 months ago

prakashks20 commented 6 months ago

Ant Design Pagination enhanced feature added in https://github.com/ant-design/ant-design/pull/46757 depends this PR changes

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 5:20pm
prakashks20 commented 5 months ago

@MadCcc Waiting for this PR approval

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (998957f) 98.70% compared to head (8efdfaa) 98.71%. Report is 1 commits behind head on master.

:exclamation: Current head 8efdfaa differs from pull request most recent head 0bcabf1. Consider uploading reports for the commit 0bcabf1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #554 +/- ## ======================================= Coverage 98.70% 98.71% ======================================= Files 3 3 Lines 310 311 +1 Branches 137 138 +1 ======================================= + Hits 306 307 +1 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prakashks20 commented 5 months ago

@MadCcc I Waiting for PR approval long time. Can you check this PR code ASAP?

prakashks20 commented 5 months ago

@MadCcc How to update the testing snapshot in the rc-pagination repository? Please help it to resolve the above coverage check failure.

yoyo837 commented 5 months ago

Add some test case to fix coverage test failed.

MadCcc commented 5 months ago

Combine all props related with sizeChanger together would be better, and could reuse props of Select.

pageSizeChanger: {
  onChange,
  options,
  showSearch,
}
Enigama commented 3 months ago

@prakashks20 how it's going? Do you need any help, because I need this fix as well?