fix: Pagination sizeOptions select search handled by showSizeOptionsSearch prop

[Enigama]

Add ability to control sizeOptions select to have search or not ant-design-issue ant-design-pr

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pagination	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 18, 2024 7:08am

[Enigama]

@yoyo837 @afc163

[yoyo837]

CI failed.

[Enigama]

@yoyo837 I see, can you advice how to run test and coverage locally? Is it possible?

[yoyo837]

You only need to run npm run test locally. You can try deleting the node_modules and lock files and reinstalling them.

[yoyo837]

[Enigama]

@yoyo837 what kind of node version do you use? Mine is 18.17.0. I've tried to delete node_modules and lock file but anyway got the same test errors.

[Enigama]

@yoyo837 Weird when I run test in cloned pagination it's ok, but when in forked it's broken.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.72%. Comparing base (b89cb0e) to head (cc663c8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #565 +/- ## ========================================== + Coverage 98.70% 98.72% +0.01% ========================================== Files 3 3 Lines 310 314 +4 Branches 137 140 +3 ========================================== + Hits 306 310 +4 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[Enigama]

@yoyo837 Should we change snap manually?

[afc163]

See https://github.com/react-component/pagination/pull/554#issuecomment-1884129690 for API

[Enigama]

@afc163 @yoyo837 if I make these changes it would lead some braking changes, doesn't it?

[afc163]

Just make the original property still working but deprecated.

[yoyo837]

@yoyo837 what kind of node version do you use? Mine is 18.17.0. I've tried to delete node_modules and lock file but anyway got the same test errors.

I'm using Nodejs v18.19.1. I think this may have nothing to do with the difference in node versions between you and me.

[Enigama]

@afc163 i'm using next version of this package v4.0.5 in deprecation message

[Enigama]

@afc163 @yoyo837 @MadCcc can you approve, now should work well

[Enigama]

@afc163 @yoyo837 @MadCcc can we merge it?

[Enigama]

@yoyo837 @afc163 can you reopen, I accidentally close PR

[yoyo837]

We can’t reopen. Feel free to open an new one.