Closed tnyo43 closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
picker | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 9, 2024 9:46am |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5db4fbe
) 98.57% compared to head (8bfd695
) 98.53%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@zombieJ @li-jia-nan @MadCcc Could you take a look and help move this improvement forward?
Sorry for delay. It's by design. onChange
is not same as onCalendarChange
.
ref: https://github.com/react-component/picker/issues/757#issuecomment-1965675890
It's by design.
Ok, if that's the case, we still have an issue with the types. I'm thinking of addressing it in another PR, so I would appreciate it if you could check it out.
close #757
I fix the first argument of the
onChange
of theRangePicker
when values are cleared. Currently, when I clear the values of theRangePicker
, the first argument of theonChange
isnull
. The type of theonChange
is((dates: NoUndefinedRangeValueType<Date>, dateStrings: [string, string]) => void) | undefined
, so the first argument can't benull
.On the other hand, that of the
onCalendarChange
function is[null, null]
and it makes sence if theonChange
is so.