react-component / picker

📅 All Date Pickers you need.
https://picker.react-component.now.sh/
MIT License
275 stars 315 forks source link

enhance: opt picker time panel hover to show as placeholder #858

Closed zombieJ closed 1 month ago

zombieJ commented 1 month ago

ref https://github.com/ant-design/ant-design/issues/50288

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 7:13am
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (e2db7d2) to head (2c82e44). Report is 6 commits behind head on master.

Files Patch % Lines
src/PickerPanel/TimePanel/TimePanelBody/index.tsx 81.25% 6 Missing :warning:
...PickerPanel/TimePanel/TimePanelBody/TimeColumn.tsx 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #858 +/- ## ========================================== - Coverage 95.41% 95.16% -0.25% ========================================== Files 64 64 Lines 2680 2709 +29 Branches 727 757 +30 ========================================== + Hits 2557 2578 +21 - Misses 120 128 +8 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shmdhussain commented 1 month ago

This is causing issues when the component is used alone see this code sandbox:

you will see the errors in the console once you hover over the time panel column values.

Error screenshot:

Screenshot 2024-08-27 at 21 32 24