react-component / scroll-anim

Animate Scroll React Component
http://react-component.github.io/scroll-anim/
MIT License
305 stars 43 forks source link

Dynamic playScale in timeline not working #47

Open navratill opened 4 years ago

navratill commented 4 years ago

Hello, if the dynamic value of playScale property is used in a timeline with the Parallax component when I change the playScale values after the first render (e.g. because of the window resize), it crashes.

Without dynamic values the timeline works fine. Try to put dynamic playScale not on the 0 index of animation, but farther.

<ScrollParallax
    animation={[
      {
            opacity: 1,
            playScale: [1, 1 + contentViewportHeight] // this is fine, contentViewportHeight value is around 0.5 in my test
      },
      {
            opacity: 0,
            playScale: [1 - contentViewportHeight, 1], // because of this value is changing, it crashes
            onStart: () =>
                this._updateState({ imageIndex: 1 }),
            onCompleteBack: () =>
                this._updateState({ imageIndex: 0 })
      }
   ]}
   component={StyledOverlay}
   style={{ opacity: 0 }}
/>
jljsj33 commented 4 years ago

Can you mention the recurrence step and demo?