react-component / select

React Select
https://select.react-component.now.sh/
MIT License
902 stars 457 forks source link

RTL Support #282

Open ghost opened 6 years ago

ghost commented 6 years ago

I want to add RTL support to react-component libraries and for the first step I choose select component. what is your preferred solution for this. using a global css like

body[dir="rtl"] .rc-select {
    /*right to left styles here*/
}

or passing some property like isRTL to component from jsx

<Select isRTL={true} ...>
  ...
</Select>

and change the css class to something is optimized for RTL language

.rc-select-rtl {
    /*right to left styles here*/
}
yutingzhao1991 commented 6 years ago

related issue https://github.com/ant-design/ant-design/issues/4051