search

react-component / select

React Select
https://select.react-component.now.sh/
MIT License
892 stars 452 forks source link

Use keyof #930

Open MixusMinimax opened 1 year ago

MixusMinimax commented 1 year ago

Existing Code

export interface SelectProps<ValueType = any, OptionType extends BaseOptionType = DefaultOptionType> extends BaseSelectPropsWithoutPrivate {
    //...
    optionFilterProp?: string;
}

Proposed Code

export interface SelectProps<ValueType = any, OptionType extends BaseOptionType = DefaultOptionType> extends BaseSelectPropsWithoutPrivate {
    //...
    optionFilterProp?: keyof OptionType;
}

This will give use better autocomplete.