react-component / select

React Select
https://select.react-component.now.sh/
MIT License
892 stars 452 forks source link

refactor: rm showArrow prop #956

Closed MuxinFeng closed 11 months ago

MuxinFeng commented 1 year ago

https://github.com/ant-design/ant-design/issues/43224

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ❌ Failed (Inspect) Jul 13, 2023 7:45am
MuxinFeng commented 1 year ago

还需要再调整下~

codecov[bot] commented 1 year ago

Codecov Report

Merging #956 (7d30cd9) into master (53bf823) will increase coverage by 0.14%. The diff coverage is 100.00%.

:exclamation: Current head 7d30cd9 differs from pull request most recent head bc4f222. Consider uploading reports for the commit bc4f222 to get more accurate results

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage   99.63%   99.77%   +0.14%     
==========================================
  Files          37       37              
  Lines        1356     1356              
  Branches      393      369      -24     
==========================================
+ Hits         1351     1353       +2     
+ Misses          4        3       -1     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/BaseSelect.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

afc163 commented 1 year ago

这是准备做 break change 么?

MuxinFeng commented 1 year ago

这是准备做 break change 么?

是的,打算将 arrow-icon 做成 suffixIcon 的一个默认值

afc163 commented 11 months ago

ci 挂了

MuxinFeng commented 11 months ago

ci 挂了

这个还需要再调整一下哈,antd 那边改的快照太多了

yoyo837 commented 11 months ago

4.x修不修

MuxinFeng commented 11 months ago

4.x修不修

4.x 在文档说明下吧,这次的改动算是 feature 了,而且涉及 tree-select、cascader,改动比较多。