react-component / select

React Select
https://select.react-component.now.sh/
MIT License
892 stars 452 forks source link

New aria-label attribute broke Playwright tests #973

Closed yfrommelt closed 8 months ago

yfrommelt commented 11 months ago

Since this commit https://github.com/react-component/select/commit/b2d241fc6a7fcea66bd2b744f017c7d3c5e75881, all playwright test can no longer focus select by label. All select on my form have the exact same label now. There is an alternative way to do the same selection as before. Or there is a way to customize the value of aria-label ? I'm using antd@5.8.2 atm.

afc163 commented 10 months ago

Could you provide a reproduce test case?

yfrommelt commented 10 months ago

I've done a simple test repo https://github.com/yfrommelt/rc-select-tests. First commit with the last version of rc-select example test fail to reach select with label. Second commit with a downgrade to rc-select@14.7.3 tests run smoothly.

pierluigigiancola commented 8 months ago

Upgrading to antd5 also broke some of my test since the label get overwritten by 'Search'

pierluigigiancola commented 8 months ago

@afc163 thanks 😄