react-component / select

React Select
https://select.react-component.now.sh/
MIT License
892 stars 452 forks source link

refactor: Select use `@rc-component/trigger` align logic instead of self measure #976

Closed zombieJ closed 10 months ago

zombieJ commented 10 months ago

ref https://github.com/ant-design/ant-design/issues/44354 close #975

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ❌ Failed (Inspect) Aug 23, 2023 9:23am
codecov[bot] commented 10 months ago

Codecov Report

Merging #976 (9fcd890) into master (2decf05) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 9fcd890 differs from pull request most recent head de8854b. Consider uploading reports for the commit de8854b to get more accurate results

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
- Coverage   99.78%   99.78%   -0.01%     
==========================================
  Files          38       38              
  Lines        1372     1369       -3     
  Branches      400      399       -1     
==========================================
- Hits         1369     1366       -3     
  Misses          3        3              
Files Changed Coverage Δ
src/BaseSelect.tsx 100.00% <100.00%> (ø)
src/SelectTrigger.tsx 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yoyo837 commented 10 months ago

rc-trigger align logic 是笔误吗? rc-trigger不是干掉了吗?

zombieJ commented 10 months ago

rc-trigger align logic 是笔误吗? rc-trigger不是干掉了吗?

updated~