search

react-component / select

React Select
https://select.react-component.now.sh/
MIT License
892 stars 452 forks source link

`event.which` is deprecated which causes issues when using @testling-library/user-event v14 #977

Open kapiljaveri opened 10 months ago

kapiljaveri commented 10 months ago

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which

Issue found here - https://github.com/testing-library/user-event/issues/1137

It's recommended to switch over to event.code or event.key instead - https://github.com/testing-library/user-event/issues/842#issuecomment-1019528148

kapiljaveri commented 10 months ago

Probably looks like we also need to change - https://github.com/react-component/util/blob/master/src/KeyCode.ts