react-component / slider

React Slider
https://slider.react-component.now.sh/
MIT License
3.02k stars 764 forks source link

fix(Handle): add aria-orientation on handles #859

Closed 5im0n closed 1 year ago

5im0n commented 1 year ago

The aria-orientation attribute indicates whether the element's orientation is horizontal, vertical.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-orientation

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
slider ❌ Failed (Inspect) Feb 16, 2023 at 1:51PM (UTC)
codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3bb74da). Click here to learn what that means. The diff coverage is 100.00%.

:exclamation: Current head fe245c5 differs from pull request most recent head 7c9ab5b. Consider uploading reports for the commit 7c9ab5b to get more accurate results

@@            Coverage Diff            @@
##             master     #859   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?       13           
  Lines             ?      537           
  Branches          ?      149           
=========================================
  Hits              ?      536           
  Misses            ?        1           
  Partials          ?        0           
Impacted Files Coverage Δ
src/Handles/Handle.tsx 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more