search

react-component / slider

React Slider
https://slider.react-component.now.sh/
MIT License
3.04k stars 772 forks source link

fix(allowCross): When two handles coincide (i.e pushNum = 0 || pushab… #904

Open nag-murali opened 1 year ago

nag-murali commented 1 year ago

…le = false, allowCross === false ) and you can move the handle across the other handle which should not be the case

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 6:03am
yoyo837 commented 7 months ago

Please add some test case for it.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c790ca8) 100.00% compared to head (98924f5) 99.46%.

Files Patch % Lines
src/hooks/useOffset.ts 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #904 +/- ## =========================================== - Coverage 100.00% 99.46% -0.54% =========================================== Files 13 13 Lines 558 565 +7 Branches 169 164 -5 =========================================== + Hits 558 562 +4 - Misses 0 3 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

afc163 commented 7 months ago
图片

Please add some test case for it.