react-component / slider

React Slider
https://slider.react-component.now.sh/
MIT License
3.02k stars 763 forks source link

fix: slider track draggale range height/width error #908

Closed BoyYangzai closed 1 year ago

BoyYangzai commented 1 year ago
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ❌ Failed (Inspect) May 30, 2023 0:41am
codecov[bot] commented 1 year ago

Codecov Report

Merging #908 (a0b85e9) into master (a951a0b) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head a0b85e9 differs from pull request most recent head 8092679. Consider uploading reports for the commit 8092679 to get more accurate results

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files          13       13              
  Lines         537      536       -1     
  Branches      140      139       -1     
==========================================
- Hits          536      535       -1     
  Misses          1        1              
Impacted Files Coverage Δ
src/Tracks/Track.tsx 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

miloszmaki commented 1 year ago

@BoyYangzai thanks for the fix, dragging works well now :+1: however there is some subtle rendering issue now, the track is being rendered over the handles, see https://codesandbox.io/s/draggable-slider-forked-dw6ele

BoyYangzai commented 1 year ago

@miloszmaki hello i just adjust the css maybe it's normal reder? can you describe carefully more

miloszmaki commented 1 year ago

@BoyYangzai this is how it looked before (v10.1.1): https://codesandbox.io/s/draggable-slider-izgbr4 before and this is how it looks now (v10.2.0): https://codesandbox.io/s/draggable-slider-forked-dw6ele now

BoyYangzai commented 1 year ago

@miloszmaki done~ https://github.com/react-component/slider/issues/912