Fix supportRef function for preact

[SpaNb4]

Fixes the issue described in https://github.com/ant-design/ant-design/pull/44135

Why the issue exists: The highlighted code in rc-dropdown returns true for react and false for preact https://github.com/react-component/dropdown/blob/master/src/Overlay.tsx#L25

Screenshot


That's why the focus doesn't shift to the menu when using preact.

Now let's take a look at the supportRef code and add some console.log to it for debugging:

Screenshot


And here are the results:

react


preact


So, based on the screenshots above, we can conclude that in the case of preact, the nodeOrComponent is a function, not an object, so the second condition is fulfilled and false is returned.

And to fix this I added an additional condition because in the screenshot above you can see that preact as well as react have a $$typeof property equal to Symbol(react.forward_ref)

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
util	❌ Failed (Inspect)			Dec 27, 2023 11:58am

[SpaNb4]

@MadCcc @zombieJ Could you please review this PR?

[mellis481]

@MadCcc @afc163 @zombieJ Can you please review and merge this PR? It's critical for my team.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5a3231f) 91.51% compared to head (105a436) 91.54%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #477 +/- ## ========================================== + Coverage 91.51% 91.54% +0.03% ========================================== Files 38 38 Lines 919 923 +4 Branches 280 284 +4 ========================================== + Hits 841 845 +4 Misses 76 76 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[afc163]

@MadCcc 看看这个

[SpaNb4]

@MadCcc Could you please review this PR?

[mellis481]

@MadCcc Bump.

[mellis481]

@MadCcc Help!

[mellis481]

@afc163 Can you please help get this PR merged?

[afc163]

ping @MadCcc @zombieJ

[MadCcc]

Could we add test for preact?

[zombieJ]

Checked for React 16, seems safe to merge.