search

react-cosmos / rfcs

Change requests for React Cosmos
MIT License
1 stars 2 forks source link

Ability to disable react-error-overlay #11

Open jedireza opened 4 years ago

jedireza commented 4 years ago

While refactoring many files one may create compile warnings across multiple files. Because react-error-overlay doesn't let you see the component/fixture you're working on until there are no errors, you can't easily iterate through files one at a time. You have to go fix all the compile errors before viewing the component you're currently working on.

You can inspect the overlay and delete it from the DOM showing the component/fixture you're working on.

ovidiuch commented 4 years ago

The root issue might be that all fixtures are bundled together, so if you have a compile error in one of your fixtures webpack can't bundle any fixtures.

jedireza commented 4 years ago

It's bundling them, but react-error-overlay renders over what's visible in the view port. The same errors are still shown in the dev console. It would be really nice to make this a config setting.

ovidiuch commented 4 years ago

Can you post a screenshot of the error overlay? I'm curious if it's a compilation error, a module runtime error or a render runtime error. If it's the 1) webpack can't bundle. If it's 3) it only appears on the component that crashes, the rest should load just fine. Maybe it's 2). Or maybe it's some linting/optional errors that I'm not familiar with.

jedireza commented 4 years ago

Or maybe it's some linting/optional errors that I'm not familiar with.

It's probably this. IIRC it was some type checking errors. I don't have a screenshot in this case.