search

react-d3 / react-d3-basic

Basic d3 charts in React.js, only include: line, bar, pie, scatter, area charts.
http://reactd3.org/docs/basic
221 stars 117 forks source link

required Proptypes for axis missing from LineChart #27

Closed yinghaochan closed 8 years ago

yinghaochan commented 8 years ago

https://github.com/react-d3/react-d3-core/blob/master/src/axis/xaxis.jsx Following the Docs demo, it doesn't seem LineChart passes any props.

https://github.com/react-d3/react-d3-basic/blob/master/src/line.jsx

chilijung commented 8 years ago

Yes it did.

https://github.com/react-d3/react-d3-basic/blob/master/src/line.jsx#L17-L20

<Chart>

will clone all the props and send to it's children. See here.

https://github.com/react-d3/react-d3-shape/blob/master/src/chart.jsx#L87-L114

yinghaochan commented 8 years ago

My bad. That's the error I'm getting, though, even with a line for line copy of the demo code.