search

react-d3 / react-d3-basic

Basic d3 charts in React.js, only include: line, bar, pie, scatter, area charts.
http://reactd3.org/docs/basic
221 stars 117 forks source link

Allow React 15.x+ on peer dependency #43

Open igorsantos07 opened 7 years ago

1999 commented 7 years ago

@chilijung hey, could you please review this PR? Currently we have peerdependencies problems with this.

igorsantos07 commented 7 years ago

this project seems abandoned :(

nmqanh commented 7 years ago

Yeah I think this one should be updated and published!

rundef commented 7 years ago

Yes please merge

jimmed commented 7 years ago

Just another :+1:

This is making an otherwise great project pretty muhc unusable

1999 commented 7 years ago

Unfortunately this PR is not enough to fix the issue because of this package's own react-d3-core and react-d3-shape dependencies. We need to extend the list of this package maintainers.

@chilijung please find time to look at this issue and extend the list of maintainers. I'm not a d3 fan but I can find time to fix this for example. @Udokah afaik react-d3-tooltip has the same issue, right? @vartika-skyport react-d3-core and react-d3-shape has the same issue with react@15 support. Do you have any plans on fixing it?

wiesson commented 7 years ago

Any updates?