search

react-d3 / react-d3-shape

react-d3 shapes, such as line, scatter, bar, bar stack ... and more.
24 stars 40 forks source link

Propagate labels to Axis components #6

Closed benhowes closed 8 years ago

benhowes commented 8 years ago

Currently the x/y labels from a <Chart > do not seem to be passed to a <YAxis>.

I've stepped through and found that something like:

<LineChart
              title='Training time vs plan'
              width={800} height={300}
              data={d3data}
              chartSeries={chartSeries}
              x={x}
              yLabel=' Time (Minutes)'
              xLabel='Plan week'
              margins={{top: 20, right: 50, bottom: 20, left: 100}}
            />

Does not lead to the labels being shown (but other x/y properties such as domain are passed down).

benhowes commented 8 years ago

@chilijung Hopefully this is a real simple one to merge in?