react-dnd / react-dnd-html5-backend

HTML5 backend for React DnD [Legacy Repo]
MIT License
146 stars 97 forks source link

How can I use it while keeping compatible with IE8? #3

Closed infinnie closed 9 years ago

infinnie commented 9 years ago

Recently I’ve been dealing with compatibility issues of a project using React-DnD. Now exactly because of the code from react-dnd-html5-backend, the web app ceases to work in IE8. What can I do?

gaearon commented 9 years ago

Maybe due to getter usage? You can try removing it. If it works, you can add a feature check like canDefineProperty and change the code to use it.

infinnie commented 9 years ago

Seems a problem caused by addEventListener :( Maybe it can be overcome by hijacking the addEventListener/removeEventListener properties to jQuery calls I guess :sleeping:

gaearon commented 9 years ago

It is not wise to depend on jQuery for the sake of two methods. jQuery isn't magic. Take a look at what it does and do the same. For example, maybe IE8 needs node.attachEvent instead or something similar.

infinnie commented 9 years ago

Yup :)

gaearon commented 9 years ago

Closing. Please feel free to create a fork doing this. We don't plan to officially support IE8 in this repo.