search

react-dropzone / attr-accept

JavaScript implementation of the "accept" attribute for HTML5 input element
MIT License
110 stars 24 forks source link

Dropped a RegExp in favour of an .endsWith #27

Closed Pimm closed 6 years ago

Pimm commented 6 years ago

I personally feel this makes the code slightly easier to read. .endsWith is already used the line immediately above the changed one. Therefore, I see no reason not to use it.

Perhaps there's a performance benefit as well, I don't know.

okonet commented 6 years ago

CI has failed. Can you please check it out?

Pimm commented 6 years ago

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file withnpm installbefore continuing.

My guess after a quick peek is that it is caused by size-limit ‒ added in 15e94f5361437bf341880915e42044a1f88b4c22 ‒ not being in package-lock.json.

okonet commented 6 years ago

Argh! Thanks! Can you update the lock file please?

Pimm commented 6 years ago

Sure. See #28.

If you merge that first, I'll rebase this PR.

okonet commented 6 years ago

Merged!

Pimm commented 6 years ago

All green!